Skip to content

Bun's numeric Windows file IDs can round together and pass a replacement check

env paths · case

bothsilentciscriptagentfirst-partyrepro: historicalwin32-file-id-number-rounding
Affectsbun, windows, actions runner
Fails asASSERTION MISMATCH
Mechanismwin32 file id number rounding
Safe fixbigint file identity

A TOCTOU guard checks that a file still has the same identity between a pre-open check and opening SQLite. On Bun 1.4.0 for Windows, the replacement test failed intermittently: a different regular file at the path passed the identity comparison.

The affected test was codex-log-guard-maintenance-coderabbit: rejects a regular-file replacement between the pre-open check and SQLite open (windows-latest job 107059048170).

Read a file’s dev and ino with ordinary numeric stats, replace the file at the same path, then compare the second numeric dev and ino to the first. On Bun 1.4.0/Windows, distinct 64-bit file IDs can round to the same JavaScript number, so the comparison can report an identity match. The CI replacement test observed this intermittently.

Ordinary Bun 1.4.0 stats expose Windows dev and ino as JavaScript numbers. JavaScript numbers cannot exactly represent every 64-bit integer, so distinct Windows file IDs can round to the same value and make an identity comparison pass for a replacement.

NTFS tunneling can also preserve a name’s creation time after that name is deleted and recreated. birthtime therefore does not provide a reliable replacement identity either.

PR #5656 switches the guard to lstatSync(path, { bigint: true }) and fails closed if dev or ino is missing, null, or zero.

Read identity fields as bigint and reject unknown identity values before opening the file:

const info = lstatSync(path, { bigint: true });
if (info.dev == null || info.ino == null || info.dev === 0n || info.ino === 0n) {
throw new Error("unknown file identity");
}

Do not substitute birthtime as identity. NTFS tunneling can retain that time when a name is recreated, so the replacement may appear to be the original.